First test

You need to be logged in to post messages in the forums. New users may register here.

Guillaume Kulakowski

Member since:
09 January 2008

Posts: 21

Wednesday 30 September 2009 1:30:24 am

Hi,

Thank for accept me in this team ;-).

I have commited a first test in http://svn.projects.ez.no/ezcodensiffer/branches/sandboxes/llaumgui/

- I use Generic and PEAR coding standard.
- I remove some PEAR standard
- I modify some other...

My blog : http://www.llaumgui.com
eZC on RHEL : http://blog.famillecollet.com/pages/Config-en
eZC on Fedora : just "yum install php-channel-ezc"

Up

Gaetano Giunta

Member since:
09 January 2008

Posts: 152

Wednesday 30 September 2009 1:50:41 am

Thanks - I moved your code around in the svn repo, trying to conform to a more 'standard' eZ naming (we still have to make up our minds about the official standard, but there are at least a couple of known variants). Gonna check it as soon as I have a few spare minutes
Up

Gaetano Giunta

Member since:
09 January 2008

Posts: 152

Wednesday 30 September 2009 1:51:42 am

Ps: starting with the pear standard is the way to go - 1st goal is fixing it so that it does not spit out 10.000 warnings on ezp code
Up

Guillaume Kulakowski

Member since:
09 January 2008

Posts: 21

Wednesday 30 September 2009 4:32:42 am

OK.

TODO :
- Check doxygen comment instead phpDoc
- Check eZ Publish files and classes comment
- Better test about for ControlStructures
- Move some error on warning...

Any idea ?

My blog : http://www.llaumgui.com
eZC on RHEL : http://blog.famillecollet.com/pages/Config-en
eZC on Fedora : just "yum install php-channel-ezc"

Up

Gaetano Giunta

Member since:
09 January 2008

Posts: 152

Wednesday 30 September 2009 5:54:09 am

- There should be some tests that apply to extensions, other to kernel code, some to both
- for extensions, usage of mysql_, mysqli_ or oci_ functions should be flagged as warning (it is acceptable only for db-handler extensions)
- spacing in function calls, the 'ezp' way
Up

Gaetano Giunta

Member since:
09 January 2008

Posts: 152

Tuesday 03 November 2009 2:59:13 am

Other tests:
- not using functions that are not available or not working on all platforms (win, solaris, linux), such as strptime or glob
Up

Guillaume Kulakowski

Member since:
09 January 2008

Posts: 21

Thursday 25 February 2010 12:44:07 am

With eZ Publish 4.3, some officials extentions have a new coding standard closer than PEAR... This projects is deprecated... I think we would must wait...

http://projects.ez.no/content/view/full/20257

My blog : http://www.llaumgui.com
eZC on RHEL : http://blog.famillecollet.com/pages/Config-en
eZC on Fedora : just "yum install php-channel-ezc"

Up

Gaetano Giunta

Member since:
09 January 2008

Posts: 152

Monday 19 April 2010 6:06:25 am

I think we should stick to the original goal of providing an 'ezpublish standard' sniffer.
Sniffers for ezc / new standards are welcome but not primary goal at the moment.
Wrt the discussion on the ezextensionbuilder forum, I think we can try to come up with:

- a set of sniffer rules for templates (even though it's not php, it should be doable)

- a set of sniffer rules for ini files

- some broader set of scripts that implements guidelines such as described here: http://share.ez.no/forums/general/ez-publish-check-is-out
Up

You need to be logged in to post messages in the forums. New users may register here.